Garrett D'Amore wrote:
> Everyone,
> 
> I've posted my latest diffs for Alchemy PCI support (and probably a few
> other Alchemy fixes as well -- I didn't want to split them all out --
> kind of painful to do that) into a diff file at
> 
>     http://garrett.damore.org/software/netbsd/aupci.diff
>
> Constructive criticism is welcomed.  Flames to /dev/null.

Use const more.  For instance, obiodev_t arrays should be const.
In machdep.c, cpus[] should be const and make name [8] instead of
a pointer.

be consistent.  either use obiodev_t everywhere or struct obiodev
but don't mix them.

Add file-system TMPFS to the config files.

Are the interrupts evcnt'ed?
-- 
Matt Thomas                     email: matt@3am-software.com
3am Software Foundry              www: http://3am-software.com/bio/matt/
Cupertino, CA              disclaimer: I avow all knowledge of this message.