Port-mips archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

pmap - PV_MODIFIED / PV_REFERENCED bits in pv_flags?



pmap_remove_pv() copies PV_MODIFIED | PV_REFERENCED bits set in
pv_flags.  I don't think that this happens now that PV_MODIFIED and
PV_REFERENCED bits are only set in pvh_attrs because these are per
physical page property, not per virtual map (pv_entry).  This coded
was added in 1.75, at that time pvh_attrs didn't exist.  I guess that
pv_flags in the first pv_entry was used as what pvh_attrs does (== per
physical page property).

I think that the following lines could be removed safely.

1.75      mhitch   2047:                        /*
                   2048:                         * Copy current
modified and referenced status to
                   2049:                         * the following entry
before copying.
                   2050:                         */
1.130     chs      2051:
1.75      mhitch   2052:                        npv->pv_flags |=
                   2053:                            pv->pv_flags &
(PV_MODIFIED | PV_REFERENCED);

I have not tested at all. :)))

Masao


Home | Main Index | Thread Index | Old Index