Re: has anyone besides me tried to build any evbmips kernels lately?

[Matt Thomas <matt%3am-software.com@localhost>]

On Dec 16, 2009, at 10:03 AM, Greg A. Woods wrote:

> At Wed, 16 Dec 2009 17:56:40 +1100, matthew green 
> <mrg%eterna.com.au@localhost> wrote:
> Subject: re: has anyone besides me tried to build any evbmips kernels lately?
>> 
>> 
>>   On Tue, Dec 15, 2009 at 07:23:28PM -0500, Greg A. Woods wrote:
>>> has anyone besides me tried to build any evbmips kernels lately?
>> 
>>   Is that a rhetorical question?
>> 
>> must be:
>> 
>> netbsd: ELF 64-bit LSB executable, MIPS, MIPS64 version 1 (SYSV), statically 
>> linked, for NetBSD 5.99.22, not stripped
>> -rwxrwxr-x  1 mrg  mrg  3896345 Dec 14 21:43 netbsd
>> 
>> build from evbmips MALTA64.
> 
> I'm very sorry, I should have said I'm trying to build kernel with the
> AP30 config file, and that it appeared some of the atheros code in
> particular had gone a bit stale over the past few years.
> 
> 
> Taking David's instructions and adding the missing #include to ar5312.c,
> just as I see it is already in ar5315.c, solved that problem:  (Thanks!)
> 
> Index: sys/arch/mips/atheros/ar5312.c
> ===================================================================
> RCS file: /cvs/master/m-NetBSD/main/src/sys/arch/mips/atheros/ar5312.c,v
> retrieving revision 1.5
> diff -u -r1.5 ar5312.c
> --- sys/arch/mips/atheros/ar5312.c    23 Jan 2008 05:23:59 -0000      1.5
> +++ sys/arch/mips/atheros/ar5312.c    16 Dec 2009 17:33:47 -0000
> @@ -54,6 +54,7 @@
> #include <sys/systm.h>
> #include <sys/kernel.h>
> #include <sys/buf.h>
> +#include <sys/device.h>
> 
> #include <mips/cache.h>
> #include <mips/locore.h>
> 
> 
> 
> I then encounter the following warning:
> 
> cc1: warnings being treated as errors
> /rest/work/woods/m-NetBSD-current/sys/arch/mips/atheros/arbus.c: In function 
> 'arbus_print':
> /rest/work/woods/m-NetBSD-current/sys/arch/mips/atheros/arbus.c:153: warning: 
> format '%lx' expects type 'long unsigned int', but argument 2 has type 
> 'bus_addr_t'
> 
> Which I've fixed very conservatively, and thus probably incorrectly or
> at least inefficiently, as follows:
> 
> Index: sys/arch/mips/atheros/arbus.c
> ===================================================================
> RCS file: /cvs/master/m-NetBSD/main/src/sys/arch/mips/atheros/arbus.c,v
> retrieving revision 1.10
> diff -u -r1.10 arbus.c
> --- sys/arch/mips/atheros/arbus.c     4 Sep 2006 05:17:26 -0000       1.10
> +++ sys/arch/mips/atheros/arbus.c     16 Dec 2009 17:46:03 -0000
> @@ -150,7 +150,7 @@
>               aprint_normal("%s at %s", aa->aa_name, pnp);
> 
>       if (aa->aa_addr)
> -             aprint_normal(" addr 0x%lx", aa->aa_addr);
> +             aprint_normal(" addr 0x%qx", (quad_t) aa->aa_addr);
> 
>       if (aa->aa_cirq >= 0)
>               aprint_normal(" cpu irq %d", aa->aa_cirq);
> 
> 
> There are then a couple of unused variables in atheros/machdep.c:
> 
> cc1: warnings being treated as errors
> /rest/work/woods/m-NetBSD-current/sys/arch/evbmips/atheros/machdep.c: In 
> function 'mach_init':
> /rest/work/woods/m-NetBSD-current/sys/arch/evbmips/atheros/machdep.c:223: 
> warning: unused variable 'v'
> /rest/work/woods/m-NetBSD-current/sys/arch/evbmips/atheros/machdep.c:222: 
> warning: unused variable 'pcb0'

Those were fixed last night.  And that arbus fix is incorrect. :)