Port-prep archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

gcc48 patches



Fix/eliminate unused-but-set variables:

+Index: sys/arch/prep/stand/boot/pci.c
+===================================================================
+RCS file: /cvsroot/src/sys/arch/prep/stand/boot/pci.c,v
+retrieving revision 1.1
+diff -u -b -r1.1 pci.c
+--- sys/arch/prep/stand/boot/pci.c     19 May 2012 14:40:12 -0000      1.1
++++ sys/arch/prep/stand/boot/pci.c     13 Mar 2014 01:11:36 -0000
+@@ -158,7 +158,6 @@
+       int slot, r;
+       struct PCI_cinfo *pslot;
+       int VGAslot = -1;
+-      int highVGAslot = 0;
+ + for (slot = start + 1; slot < PCI_NSLOTS; slot++) {
+               pslot = &PCI_slots[slot];
+@@ -171,7 +170,6 @@
+                           ((pslot->regs[CLASS] & 0xffffff00) ==
+                               0x00010000)) {
+                               /* it's a VGA card */
+-                              highVGAslot = slot;
+                               if ((pslot->regs[CMD] & 0x03)) {
+                                       /* fW enabled it */
+                                       VGAslot = slot;
+Index: sys/arch/prep/stand/boot/siop.c
+===================================================================
+RCS file: /cvsroot/src/sys/arch/prep/stand/boot/siop.c,v
+retrieving revision 1.1
+diff -u -b -r1.1 siop.c
+--- sys/arch/prep/stand/boot/siop.c    19 May 2012 14:40:13 -0000      1.1
++++ sys/arch/prep/stand/boot/siop.c    13 Mar 2014 01:32:14 -0000
+@@ -604,7 +604,7 @@
+ {
+       struct siop_xfer *siop_xfer = adp->xfer;
+       uint32_t dsa, *script = adp->script;
+-      int target, lun, slot;
++      int slot;
+       void *scriptaddr = (void *)local_to_PCI((u_long)script);
+       const int siop_common_xfer_size = sizeof(struct siop_common_xfer);
+ +@@ -631,8 +631,6 @@
+       } else {
+               slot++;
+       }
+-      target = xs->target;
+-      lun = xs->lun;
+       /*
+        * find a free scheduler slot and load it.
+        */


There is still a complaint of "may be used uninitialized" that needs
analysis and fixing.

--
|/"\ John D. Baker, KN5UKS               NetBSD     Darwin/MacOS X
|\ / jdbaker[snail]mylinuxisp[flyspeck]com    OpenBSD            FreeBSD
| X  No HTML/proprietary data in email.   BSD just sits there and works!
|/ \ GPGkeyID:  D703 4A7E 479F 63F8 D3F4  BD99 9572 8F23 E4AD 1645



Home | Main Index | Thread Index | Old Index