I was looking through /sys/arch/sparc/dev/zs.c and I discovered that
there are quite a few hard-coded numbers there, i.e.

	ringsize=128;
	ringsize=4096;

Shouldn't these be #defined in zs.h as

#define ZSKBDRINGSIZE 128
#define ZSTTYRINGSIZE 4096

or something?  It kind of makes it look like the zs driver was kind
of thrown together.  (Oh!  Uh, hi, Chris... aheh...)

Secondly, does anyone know of any adverse effects of increasing the
ringsize?


Reply-To: greywolf@starwolf.com

This message made possible by
Microsoft
"I'VE GOT A BAD FEELING ABOUT THIS"