Subject: Re: 1.6 on IPC (tagged queuing bug still there)
To: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
From: Manuel Bouyer <bouyer@antioche.eu.org>
List: port-sparc
Date: 09/03/2002 21:55:33
On Wed, Sep 04, 2002 at 01:15:09AM +0900, Izumi Tsutsui wrote:
> In article <Pine.NEB.4.44.0209031637490.358-100000@moss.i.formula1.com>
> abs@netbsd.org
>
> > Would anyone object to defaulting tagged queuing off for esp
> > and adding a documented kernel option to enable it? This will
> > not help 1.6, but should make 1.6.1
>
> I think only ESP100 has the problem. How about this patch?
> ---
> Izumi Tsutsui
> tsutsui@ceres.dti.ne.jp
>
> --- ncr53c9x.c.orig Wed Sep 4 01:07:03 2002
> +++ ncr53c9x.c Wed Sep 4 01:13:38 2002
> @@ -1066,6 +1066,11 @@
> if (ecb->xs->xs_control & XS_CTL_POLL)
> tag = 0;
> #endif
> +#if 1
> + /* XXX tagged queuing by SELATNS seems to have some problem */
> + if ((sc->sc_features & NCR_F_SELATN3) == 0)
> + tag = 0;
> +#endif
scsipi will think the adapter can do tagged queuing while that's not true.
This one is probably better
--- ncr53c9x.c.orig Tue Sep 3 21:53:54 2002
+++ ncr53c9x.c Tue Sep 3 21:54:24 2002
@@ -901,7 +901,8 @@
ti->offset = 0;
if ((sc->sc_cfflags & (1<<(xm->xm_target+16))) == 0 &&
- (xm->xm_mode & PERIPH_CAP_TQING))
+ (xm->xm_mode & PERIPH_CAP_TQING) &&
+ (sc->sc_features & NCR_F_SELATN3) != 0)
ti->flags |= T_TAG;
else
ti->flags &= ~T_TAG;
--
Manuel Bouyer <bouyer@antioche.eu.org>
--