Re: ntpd wedged by libc?

[AGC <agcarver+netbsd%acarver.net@localhost>]

On 3/4/2012 13:02, Christos Zoulas wrote:
> On Mar 2,  9:19pm, agcarver%acarver.net@localhost (Alexander Carver) wrote:
> -- Subject: Re: ntpd wedged by libc?
>
> | On 3/2/2012 20:38, AGC wrote:
> |>  On 3/2/2012 05:30, Christos Zoulas wrote:
> |>>  On Mar 1, 9:59pm, agcarver+netbsd%acarver.net@localhost (AGC) wrote:
> |>>  -- Subject: Re: ntpd wedged by libc?
> |>>
> |>>  | The copy I have has a banner reading:
> |>>  |
> |>>  | /* $NetBSD: misc.c,v 1.4 2008/03/21 23:13:48 christos Exp $ */
> |>>  |
> |>>  | The copy I obtained from
> |>>  | ftp.netbsd.org/pub/NetBSD/NetBSD-current/src/lib/libc/gdtoa/misc.c
> |>>  | (unless this isn't head)
> |>>  |
> |>>  | Has a header:
> |>>  | /* $NetBSD: misc.c,v 1.11 2011/11/21 09:46:19 mlelstv Exp $ */
> |>>
> |>>  Yup, that's the latest.
> |>>  Get /usr/src/tests/lib/libc/stdio/t_printf.c and see if the
> |>>  snprintf_float
> |>>  test leaks for you.
> |>
> |>  # gcc -o t_printf t_printf.c
> |>  t_printf.c: In function 'atfu_snprintf_float_body':
> |>  t_printf.c:129: error: 'for' loop initial declaration used outside C99 mode
> |>
> |>
> |>
> | I also tried with the makefile:
> |
> | # make USETOOLS=never
> | #   compile  stdio/t_printf.o
> | cc -O2 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith
> | -Wno-sign-compare -Wno-traditional -Wa,--fatal-warnings -Wreturn-type
> | -Wswitch -Wshadow -Wcast-qual -Wwrite-strings -Wextra
> | -Wno-unused-parameter -std=gnu99 -Wno-missing-noreturn -Werror       -c
> | -Wno-format-nonliteral   t_printf.c
> | cc1: warnings being treated as errors
> | t_printf.c: In function 'atfu_snprintf_dotzero_body':
> | t_printf.c:52: warning: implicit declaration of function 'ATF_REQUIRE_STREQ'
>
> I guess that requires newer ATF_...
>
> #define ATF_REQUIRE_STREQ(a, b) ATF_REQUIRE(strcmp(a, b) == 0)

Ok, the first suggested define worked to allow it to compile:

#define ATF_REQUIRE_STREQ(A, B) ATF_CHECK(strcmp((A), (B)) == 0 )

I get this result:
# ./t_printf
Content-Type: application/X-atf-tcs; version="1"

tcs-count: 6
tc-start: snprintf_dotzero
__atf_tc_separator__
__atf_tc_separator__
tc-end: snprintf_dotzero, passed
tc-start: snprintf_posarg
__atf_tc_separator__
__atf_tc_separator__
tc-end: snprintf_posarg, passed
tc-start: snprintf_posarg_width
__atf_tc_separator__
__atf_tc_separator__
tc-end: snprintf_posarg_width, passed
tc-start: snprintf_posarg_error
__atf_tc_separator__
__atf_tc_separator__
tc-end: snprintf_posarg_error, failed, Test case did not exit cleanly; 
state was 138
tc-start: snprintf_float
__atf_tc_separator__
__atf_tc_separator__
tc-end: snprintf_float, failed, Test case timed out after 300 seconds
tc-start: sprintf_zeropad
tc-end: sprintf_zeropad, failed, Line 157: strcmp((str),("       nan")) 
== 0 not met