Hi Hans,
On Mon, 2025-03-10 13:08:09 +0100, Hans Rosenfeld <hans%netbsd.org@localhost> wrote:
> I've recently fixed a few bugs on VAX, and while I did that I noticed
> that ddb(4) on VAX is a pain to work with. Here's my attempt fix this:
>
> https://github.com/NetBSD/src/compare/trunk...hrosenfeld:NetBSD-src:vax-ddb
The patch contain two chunks like this:
-/* Isolate the saved register bits, and count them */
-regs = fp->vax_regs;
-for (arg_base = 0; regs != 0; regs >>= 1) {
- if (regs & 1)
- arg_base++;
-}
+/* Count saved register bits */
+arg_base = popcount(fp->vax_regs);
I'm not entirely sure, but I think both are actually not exactly
correct. While counting registers R0 .. R11 it totally fine, things
may change if for whatever reason the IV and DV flags are set (and
counted.) Maybe AND the register mask to mask out the top two bits
for safety?
> Since this is a rather large change, I'd like to give anyone interested
> a chance to do a proper code review before I commit this. I've been
> working with and on this for the past two weeks and tested this
> extensively.
I like it!
MfG, JBG
--
Attachment:
signature.asc
Description: PGP signature