Re: patch: power off

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

isaki@ wrote:

> +             /* power-off sequence */
> +             intio_set_sysport_powoff(0x00);
> +             intio_set_sysport_powoff(0x0f);
> +             intio_set_sysport_powoff(0x0f);
> +             delay(1000000);

Looks good, but it's also better to notify users as some other ports

                printf("powering off...\n");
                delay(1000000);
                intio_set_sysport_powoff(0x00);
                intio_set_sysport_powoff(0x0f);
                intio_set_sysport_powoff(0x0f);
                delay(1000000);
                printf("WARNING: powerdown failed\n");
                delay(1000000);

because console screen is also turned off.

---
Izumi Tsutsui