Subject: Re: bouyer-xenamd64 merged
To: Christoph Egger <Christoph_Egger@gmx.de>
From: Masao Uebayashi <uebayasi@gmail.com>
List: port-xen
Date: 11/23/2007 21:22:41
> IMO, the code needs a lot of cleanup. Personally I don't like the tons of
>
> #ifdef XEN
> ...
> #else
> ...
> #endif
>
> blocks. A few of them are ok, but they are too numerous now.
#ifdef's that switches by models make code hard to understand. I'd
want to see #ifdef's by features (#ifdef HAS_FOO and #ifdef IS_BAR)
even in MD code. IMHO.
Masao