Re: CVS commit: src/sys/arch/i386/i386

["Perry E. Metzger" <perry%piermont.com@localhost>]

enami tsugutomo <enami%sm.sony.co.jp@localhost> writes:
> David Holland <dholland-sourcechanges%NetBSD.org@localhost> writes:
>
>> On Tue, Mar 31, 2009 at 06:54:19AM +0900, Izumi Tsutsui wrote:
>>  > src/share/misc/style says to insert it:
>>  > [...]
>>  > { /* Insert an empty line if the function has no local variables. */
>> 
>> but but but that's clearly stupid! :-)
>
> I feel comfortable while reading code which has the empty line.
> Lacking it irritates me as if I met code like `for (i=0;i<4096;i++)'
> and I tend to lose interest on such code.

In any case, the style guide should be followed, so the original code
should have been normalized to the style guide. It would be okay to
discuss changing the style guide, but that's a different issue.

Perry
-- 
Perry E. Metzger                perry%piermont.com@localhost