Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/distrib/sets



apb%cequrux.com@localhost wrote:

> On Thu, 02 Apr 2009, Izumi Tsutsui wrote:
> > Log Message:
> > Explicitly sort entries on preparing set files from METALOG.
> > METALOG could have different order due to install(1) race
> > on parallel builds, and mtree(8) doesn't sort files.
> > Should fix inconsistent shared sets among builds as seen in
> > /pub/NetBSD-daily/netbsd-5/200904010000Z/shared/ and
> > /pub/NetBSD-daily/netbsd-5/200904010002Z/shared/ dirs.
> > Okay'ed by snj@.
> 
> I think it would be better to do this in the sanitise_METALOG target in
> src/distrib/sets/Makefile, like this:

But it is not confiremd yet that using METALOG.sanitised is okay or not.

> It would also make sense to add a sort option to mtree.

Or fix join.awk, but it's another future work.

My change is just an interim fix for actually forthcoming 5.0.
---
Izumi Tsutsui


Home | Main Index | Thread Index | Old Index