Re: CVS commit: src/sys/uvm

[Christoph Egger <Christoph_Egger%gmx.de@localhost>]

Christos Zoulas wrote:
> In article <20090418084847.77C3C175D0%cvs.netbsd.org@localhost>,
> Christoph Egger  <source-changes-d%NetBSD.org@localhost> wrote:
>> Module Name: src
>> Committed By:        cegger
>> Date:                Sat Apr 18 08:48:47 UTC 2009
>>
>> Modified Files:
>>      src/sys/uvm: uvm_pmap.h
>>
>> Log Message:
>> Introduce PMAP_MD_MASK. Reserves PMAP bits for use in MD code.
>> Presented on tech-kern@, port-i386@ and port-amd64@
>> ok ad@
> 
> It makes sense to start the MD bits from the top and the MI bits from
> the bottom instead of putting the MD bits in the middle and having the
> possibility of mixing them in the future.

This would imply to change the flags arguments of the pmap API
from int to u_int to avoid troubles with checking flag bits.

Alternatively, code like this

    if (flags & FLAG1)
        do_something();

must be converted to

    if ((flags & FLAG1) == FLAG1)
        do_something();


Christoph