Re: CVS commit: src/sys

[Elad Efrat <elad%NetBSD.org@localhost>]

On Mon, May 4, 2009 at 3:38 AM, Alistair Crooks <agc%pkgsrc.org@localhost> 
wrote:
> On Sun, May 03, 2009 at 09:25:45PM +0000, Elad Efrat wrote:
>> Module Name:  src
>> Committed By: elad
>> Date:         Sun May  3 21:25:45 UTC 2009
>>
>> Modified Files:
>>       src/sys/conf: param.c
>>       src/sys/kern: vfs_init.c
>>       src/sys/secmodel/bsd44: secmodel_bsd44.c secmodel_bsd44_logic.c suser.h
>>
>> Log Message:
>> Move dovfsusermount to secmodel_bsd44, where it really belongs.
>>
>> The secmodel code now creates the same knob in two places: both under the
>> secmodel itself, as well as the widely known location.
>>
>> Mailing list references:
>>
>>     http://mail-index.netbsd.org/source-changes/2009/05/02/msg220641.html
>>     http://mail-index.netbsd.org/tech-kern/2009/05/03/msg005015.html
>
> What about other secmodels? They'll now have to duplicate the dovfsusermount
> functionality.

Of course they will have to duplicate it, they're different secmodels.
In bsd44 it's a variable, in a different secmodel it might be a
capability, a part of a bitmap, or who knows what. Both the provided
functionality and the implementation are secmodel-specific, and as
such have no place in being "shared".

> PS. Please leave longer between proposing changes until committing them, as
> others have asked you previously. You are not giving people enough time to
> provide feedback, and so are causing yourself and others more work by doing
> this.

I didn't say I'm waiting for feedback about this change... if you will
look at tech-kern@ and tech-net@ you will see that there are several
commits "pending" that I'm not rushing in yet as there's an on-going
discussion. Please do not generalize.

Thanks,

-e.