Re: CVS commit: src/sys

[yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi)]

hi,

> Antti Kantee <pooka%NetBSD.org@localhost> wrote:
>> On Mon, May 04, 2009 at 06:05:19AM +0000, YAMAMOTO Takashi wrote:
>> > Module Name:       src
>> > Committed By:      yamt
>> > Date:              Mon May  4 06:05:19 UTC 2009
>> > 
>> > Modified Files:
>> >    src/sys/kern: vfs_lookup.c
>> >    src/sys/nfs: nfs_srvsubs.c
>> > 
>> > Log Message:
>> > when freeing cn_pnbuf, make it NULL if DIAGNOSTIC.
>> 
>> Even better if PNBUF_PUT() does it so that we catch all violations?

i don't like such a "magic" macro.

> 
> Not sure about invading PNBUF_PUT(), but I think #ifdef is not worth.

these #ifdef indicate that cn_pnbuf == NULL is not a valid test for HASBUF.
ie. this commit is not intended to modify the api.

YAMAMOTO Takashi

> 
> -- 
> Best regards,
> Mindaugas