Re: CVS commit: src/sys/kern

[Rafal Boni <rafal%pobox.com@localhost>]

On Wed, May 06, 2009 at 10:37:51PM +0200, Manuel Bouyer wrote:
> On Wed, May 06, 2009 at 01:10:04PM +0200, Manuel Bouyer wrote:
> > > Your change works around a bug with sparc64
> > 
> > it's sparc, not sparc64.
> > 
> > > or perhaps even gcc. Please
> > > address the root cause instead. Thanks.
> > 
> > I'll try to look at ports which have inline spl*() function and add missing
> > insn_barrier(). But it may not be before next week
> 
> I've been though the MD code. I filled in a PR for port-hp700,
> port-powerpc and port-sparc. All m68k and the vax port also have the
> issue (confirmed by mhitch@, thanks !)
> Other ports looks safe (they either use __insn_barrier() or assembly
> equivalent, or use real function calls).

I seem to recall arm (maybe evbarm) code being semi-inconsistent in this
respect (the spl* calls are per-board at least in many of the evbarm 
variants), but I haven't actually gone and looked... did those check
out OK as well?

(Yes, I'm being lazy, but I thought I'd note it just in case).

--rafal

-- 
  Time is an illusion; lunchtime, doubly so.     |/\/\|           Rafal Boni
                   -- Ford Prefect               |\/\/|      
rafal%pobox.com@localhost