Source-Changes-D archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: src
On Thu, Jun 18, 2009 at 03:22:24PM +0000, Havard Eidnes wrote:
> Module Name: src
> Committed By: he
> Date: Thu Jun 18 15:22:24 UTC 2009
>
> Modified Files:
> src/common/lib/libc/hash/sha2: sha2.c
> src/sys/lib/libkern/arch/vax: Makefile.inc
>
> Log Message:
> Back out the addition of memset.c to the vax libkern, and instead do
> as tsutsui@ suggested, and include <sys/param.h> in sha2.c instead.
> On the vax, this causes <machine/macros.h> to be included, and it contains
> that machine's memset() macro+inline.
I object this change to sha2.c. At the very least the include should be
in the kernel only section. Besides, I would call this a bug in VAX --
including libkern's headers should be good enough. If it isn't, that
should be fixed.
Joerg
Home |
Main Index |
Thread Index |
Old Index