Re: CVS commit: src/usr.bin/gencat

[David Holland <dholland-sourcechanges%netbsd.org@localhost>]

On Sun, Jul 12, 2009 at 11:30:36AM +0100, Matthias Scheler wrote:
>> -       if (ntohl(cat_hdr.__magic) != _NLS_MAGIC)
>> +       if (ntohl((uint32_t)cat_hdr.__magic) != _NLS_MAGIC)
>
> Yes, it's nasty.
>
>> Dare I ask how ntohl is defined on these platforms?
>
> [...]
>
> The problem was not the width of argument but the fact it is
> signed.

Right.

>> If that isn't the case it might be better to adjust how ntohl is
>> defined...?
>
> Possibly. But I didn't want to change an important global interface,
> at least not without prior discussion.

Well, discussion time! :-)

-- 
David A. Holland
dholland%netbsd.org@localhost