Source-Changes-D archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: src/sys/arch/amd64/amd64
On Fri, Jul 17, 2009 at 11:35:31AM +0000, Christos Zoulas wrote:
> >Shouldn't the non-DIAGNOSTIC default case set ksi_signo to something
> >other than 0? I'm not entirely sure what trapsignal will do with
> >signal 0, but I doubt it's the right thing.
>
> Well, if you fall in the default case in both switch statements it
> is clearly a bug (because you added another case in the outside
> switch and you forgot to add it in the inside). I could remove the
> DIAGNOSTIC check, but that leads to bloat.
True. N/m.
(Maybe the cases should be sorted in the same order though.)
--
David A. Holland
dholland%netbsd.org@localhost
Home |
Main Index |
Thread Index |
Old Index