Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/common/bus_dma



On Fri, Aug 21, 2009 at 09:30:06AM -0700, Jason Thorpe wrote:
>>> Add some common bus_dmamem routines to be shared by multiple  
>>> platforms.
>>
>> Do these really need to be in their own private directory? (whose
>> name, I might add, is confusing in the presence of src/common...)
>
> This is intended to be a collection of common routines for various  
> subsystems to use.  If we had real language / runtime support for it in 
> the kernel, these would be common implementations of base classes  
> instead.
>
> Because this will likely grow into a fairly large collection of  
> miscellaneous stuff, I figured a separate area would be appropriate.   
> sys/kern is way too cluttered as it is (and, IMO, also needs to be split 
> up a bit, but I hesitate to do it until we have a decent version control 
> system that can maintain history across moves).

The way to split up a misc directory that is too large is not to make
another misc directory.

The code you committed, being general-purpose bus architecture, ought
to live in src/sys/dev somewhere; maybe we should create
src/sys/dev/gen.

> src/common is stuff shared between kernel and userland.

I'm aware of that, and this is why the name you've chosen is confusing.

-- 
David A. Holland
dholland%netbsd.org@localhost


Home | Main Index | Thread Index | Old Index