Source-Changes-D archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
re: CVS commit: src/sys/rump
In article <20090908162339.GA11486%cs.hut.fi@localhost>,
ntti Kantee <pooka%cs.hut.fi@localhost> wrote:
>
>Whoever finds this churn worth their effort, as dh pointed out, remember
>to replace all instances of __FreeBSD__, __OpenBSD__, __Linux__,
>__Slowaris__, __sMackOS__, __etc__ as well.
The issue here is that we really don't want to override the symbols set
by the compiler because a lot of code assumes that they are going to be
set by the compiler, and not by other external means. Everytime I remember
someone did this, it had to be reverted for one reason or the other.
this is a pretty special case.
i don't think anything beyond defining __NetBSD__ and undefining
anything else used in our tree is worth it.
the way that rump is separated from the host makes this quite a
reasonable way of doing it. "rump" -- which is a virtual netbsd
kernel -- doesn't talk to userspace itself. it's a real netbsd
kernel. it is self contained and doesn't invoke the host. it
has "rumpuser" for that, and rumpuser is not compiled with
-D__NetBSD__.
.mrg.
Home |
Main Index |
Thread Index |
Old Index