Re: CVS commit: src/usr.sbin/puffs/rump_smbfs

[Antti Kantee <pooka%netbsd.org@localhost>]

On Thu Sep 10 2009 at 14:14:03 +1000, Geoff Wing wrote:
> On Sunday 2009-09-06 20:26 +0000, Antti Kantee output:
> :Module Name: src
> :Committed By:        pooka
> :Date:                Sun Sep  6 20:26:47 UTC 2009
> :Added Files:
> :     src/usr.sbin/puffs/rump_smbfs: Makefile rump_smbfs.8 rump_smbfs.c
> :         smb_rumpops.c
> :Log Message:
> :Add rump_smbfs.
> [...]
> :cvs rdiff -u -r0 -r1.1 src/usr.sbin/puffs/rump_smbfs/Makefile \
> [...]
> 
> When I did a build, it seemed to need the following patch to link
> (stolen from rump_nfs/Makefile).  Is it correct here?

No, that is *absolutely the wrong thing*, since while it might make
the build work, it breaks the resulting binary.  I'm a bit baffled that
breakage like that was committed to rump_nfs/Makefile in the first place.

It seems there is a regression in binutils 2.19 which prevents the
standard DOMAIN_DEFINE() macro from working.  I suggest reverting back
to 2.16 until the cause is identified and the bug is fixed.

> Regards,
> Geoff
> 
> PS. ``descualified''?
> 
> Index: Makefile
> ===================================================================
> RCS file: /cvsroot/src/usr.sbin/puffs/rump_smbfs/Makefile,v
> retrieving revision 1.1
> diff -u -r1.1 Makefile
> --- Makefile  6 Sep 2009 20:26:47 -0000       1.1
> +++ Makefile  10 Sep 2009 04:07:20 -0000
> @@ -9,6 +9,9 @@
>  LDADD+=      -lrumpnet_netinet -lrumpnet_sockin -lrumpnet
>  LDADD+=              -lrumpcrypto -lrumpdev_netsmb -lrumpdev
>  
> +LDFLAGS+=      -Wl,--ignore-unresolved-symbol,__start_link_set_domains
> +LDFLAGS+=      -Wl,--ignore-unresolved-symbol,__stop_link_set_domains
> +
>  ISRUMP=              # it is
>  
>  .include "${.CURDIR}/../../../sbin/mount_smbfs/Makefile.inc"