Re: CVS commit: src/usr.sbin/sup/source

[Marc Balmer <marc%msys.ch@localhost>]

Am 17.10.2009 um 00:45 schrieb Christos Zoulas:

> Module Name:    src
> Committed By:   christos
> Date:           Fri Oct 16 22:45:19 UTC 2009
>
> Modified Files:
>         src/usr.sbin/sup/source: supcmain.c supcmeat.c supscan.c
>
> Log Message:
> Make this compile again. I should have tried to compile the patches  
> myself,
> but ran out of time this morning.

I find that this attitude of "committ, maybe it compilers, maybe it  
does not, I do not care" sucks.  If you don't have time to test- 
compile, then please don't commit.  You just make everyones life  
harder by committing stuff that breaks the tree.  At least I am  
running -current on all my machines, and seeing all these tree  
breakages all the time are a waste of time, I find.

What is so fucking hard to to run a system build or so before  
commiting stuff?

- Marc



> To generate a diff of this commit:
> cvs rdiff -u -r1.28 -r1.29 src/usr.sbin/sup/source/supcmain.c
> cvs rdiff -u -r1.35 -r1.36 src/usr.sbin/sup/source/supcmeat.c
> cvs rdiff -u -r1.16 -r1.17 src/usr.sbin/sup/source/supscan.c
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
>
> Modified files:
>
> Index: src/usr.sbin/sup/source/supcmain.c
> diff -u src/usr.sbin/sup/source/supcmain.c:1.28 src/usr.sbin/sup/ 
> source/supcmain.c:1.29
> --- src/usr.sbin/sup/source/supcmain.c:1.28     Fri Oct 16 08:41:37 2009
> +++ src/usr.sbin/sup/source/supcmain.c  Fri Oct 16 18:45:18 2009
> @@ -1,4 +1,4 @@
> -/*     $NetBSD: supcmain.c,v 1.28 2009/10/16 12:41:37 christos Exp $   */
> +/*     $NetBSD: supcmain.c,v 1.29 2009/10/16 22:45:18 christos Exp $   */
>
> /*
>  * Copyright (c) 1992 Carnegie Mellon University
> @@ -599,7 +599,7 @@
>         char buf[STRINGLENGTH], *p;
>         const char *u;
>         char username[STRINGLENGTH];
> -       char *supfname, **arg;
> +       char *supfname, *arg;
>         COLLECTION *c, *lastC;
>         FILE *f;
>         int bogus;
>
> Index: src/usr.sbin/sup/source/supcmeat.c
> diff -u src/usr.sbin/sup/source/supcmeat.c:1.35 src/usr.sbin/sup/ 
> source/supcmeat.c:1.36
> --- src/usr.sbin/sup/source/supcmeat.c:1.35     Fri Oct 16 08:41:37 2009
> +++ src/usr.sbin/sup/source/supcmeat.c  Fri Oct 16 18:45:18 2009
> @@ -1,4 +1,4 @@
> -/*     $NetBSD: supcmeat.c,v 1.35 2009/10/16 12:41:37 christos Exp $   */
> +/*     $NetBSD: supcmeat.c,v 1.36 2009/10/16 22:45:18 christos Exp $   */
>
> /*
>  * Copyright (c) 1992 Carnegie Mellon University
> @@ -1483,7 +1483,7 @@
> }
>
> void
> -goaway(char *fmt, ...)
> +goaway(const char *fmt, ...)
> {
>         char buf[STRINGLENGTH];
>         va_list ap;
>
> Index: src/usr.sbin/sup/source/supscan.c
> diff -u src/usr.sbin/sup/source/supscan.c:1.16 src/usr.sbin/sup/ 
> source/supscan.c:1.17
> --- src/usr.sbin/sup/source/supscan.c:1.16      Thu Dec 20 15:17:52 2007
> +++ src/usr.sbin/sup/source/supscan.c   Fri Oct 16 18:45:18 2009
> @@ -1,4 +1,4 @@
> -/*     $NetBSD: supscan.c,v 1.16 2007/12/20 20:17:52 christos Exp $    */
> +/*     $NetBSD: supscan.c,v 1.17 2009/10/16 22:45:18 christos Exp $    */
>
> /*
>  * Copyright (c) 1992 Carnegie Mellon University
> @@ -393,7 +393,7 @@
> }
>
> void
> -goaway(char *fmt, ...)
> +goaway(const char *fmt, ...)
> {
>         va_list ap;