Re: CVS commit: src/lib/libc/stdio

[christos%astron.com@localhost (Christos Zoulas)]

In article <20091025170934.BD83C175D0%cvs.netbsd.org@localhost>,
David Laight  <source-changes-d%NetBSD.org@localhost> wrote:
>-=-=-=-=-=-
>
>Module Name:   src
>Committed By:  dsl
>Date:          Sun Oct 25 17:09:34 UTC 2009
>
>Modified Files:
>       src/lib/libc/stdio: asprintf.c fgets.c fgetwc.c fread.c fvwrite.c
>           getdelim.c
>
>Log Message:
>Lint is differentially far too picky...
>Remove some warnings that only appear on i386 (not on amd64) and that
>for some reason best known to others are deemed fatal for i386.
>Making this code 'pass lint' does absolutely nothing for its readability (etc).

Can we just revert the past 2 commits? Changing:

(size_t)x -> x + 0u

does not look like an improvement to me. At least the first shows the intent,
the second is just confusing, specially when size_t is unsigned long.

christos