Re: CVS commit: src/sys/arch/i386/i386

[David Laight <david%l8s.co.uk@localhost>]

On Sun, Nov 22, 2009 at 12:09:33AM +0000, Christos Zoulas wrote:
> In article <20091121223029.1E0D263B186%mail.netbsd.org@localhost>,
> Mindaugas Rasiukevicius  <rmind%netbsd.org@localhost> wrote:
> >Hello,
> >
> >David Laight wrote:
> >> Module Name:       src
> >> Committed By:      dsl
> >> Date:              Sat Nov 21 19:59:51 UTC 2009
> >> 
> >> Modified Files:
> >>    src/sys/arch/i386/i386: db_trace.c
> >> 
> >> Log Message:
> >> Don't call lwp_getpcb() when not KERNEL.
> >
> >Thanks for working this around, however it is not a right fix.  With this
> >patch, build.sh release passes:
> >
> >http://www.netbsd.org/~rmind/crash_pcb.diff
> >
> >It should have been enough to amend the argument of routine exported to
> >userland.  Do not you agree?
> 
> I do.
> 
> christos
> 

No - you shouldn't be making any names visible to normal user programs.
We pollute user namespace far too much as it is.

The 'fix' I did was a pragmatic one to get the build working.
Programs like crash (and gdb) need to be able to define something
in order to get these extra structures (etc) visible.


        David

-- 
David Laight: david%l8s.co.uk@localhost