Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src



On Jan 25,  8:23am, tsutsui%ceres.dti.ne.jp@localhost (Izumi Tsutsui) wrote:
-- Subject: Re: CVS commit: src

| > | As noted in the PR, the original problem is asnprintf() and
| > | vasnprinf() decls in src/include/heimdal/roken.h because
| > | Cygwin has the same functions with incompatible args
| > | (derived from GNU?) by default.
| > 
| > This is unrelated to what I changed though and was not planning to look
| > into that. Grumble, I guess I will download cygwin 1.7.1
| 
| What I need is a review of my new patch :-)
| http://mail-index.NetBSD.org/netbsd-bugs/2010/01/21/msg015707.html


Well, I'd prefer to avoid including a copy of roken.h for the tools.
I think that vasnprintf and asnprintf are not used by anything in
heimdal and can safely be removed. Combined with the winsize fix,
this fixes the cygwin problems with minimal changes. I am trying a
build now.

christos


Home | Main Index | Thread Index | Old Index