Re: CVS commit: src/lib/libterminfo

[christos%astron.com@localhost (Christos Zoulas)]

In article <20100205143907.E255D175DA%cvs.netbsd.org@localhost>,
Havard Eidnes  <source-changes-d%NetBSD.org@localhost> wrote:
>-=-=-=-=-=-
>
>Module Name:   src
>Committed By:  he
>Date:          Fri Feb  5 14:39:07 UTC 2010
>
>Modified Files:
>       src/lib/libterminfo: term.h term_private.h
>
>Log Message:
>More adaptation for ports with unsigned char as char.
>
>
>To generate a diff of this commit:
>cvs rdiff -u -r1.2 -r1.3 src/lib/libterminfo/term.h
>cvs rdiff -u -r1.3 -r1.4 src/lib/libterminfo/term_private.h
>
>Please note that diffs are not public domain; they are subject to the
>copyright notices on the relevant files.
>
>
>-=-=-=-=-=-
>
>Modified files:
>
>Index: src/lib/libterminfo/term.h
>diff -u src/lib/libterminfo/term.h:1.2 src/lib/libterminfo/term.h:1.3
>--- src/lib/libterminfo/term.h:1.2     Thu Feb  4 09:46:26 2010
>+++ src/lib/libterminfo/term.h Fri Feb  5 14:39:07 2010
>@@ -1,4 +1,4 @@
>-/* $NetBSD: term.h,v 1.2 2010/02/04 09:46:26 roy Exp $ */
>+/* $NetBSD: term.h,v 1.3 2010/02/05 14:39:07 he Exp $ */
> 
> /*
>  * Copyright (c) 2009 The NetBSD Foundation, Inc.
>@@ -1454,7 +1454,7 @@
>       /* We need to expose these so that the macros work */
>       char *name;
>       char *desc;
>-      char *flags;
>+      signed char *flags;
>       short *nums;
>       const char **strs;
> } TERMINAL;
>
>Index: src/lib/libterminfo/term_private.h
>diff -u src/lib/libterminfo/term_private.h:1.3
>src/lib/libterminfo/term_private.h:1.4
>--- src/lib/libterminfo/term_private.h:1.3     Fri Feb  5 12:31:56 2010
>+++ src/lib/libterminfo/term_private.h Fri Feb  5 14:39:07 2010
>@@ -1,4 +1,4 @@
>-/* $NetBSD: term_private.h,v 1.3 2010/02/05 12:31:56 roy Exp $ */
>+/* $NetBSD: term_private.h,v 1.4 2010/02/05 14:39:07 he Exp $ */
> 
> /*
>  * Copyright (c) 2009 The NetBSD Foundation, Inc.
>@@ -84,7 +84,7 @@
>       /* We need to expose these so that the macros work */
>       char *name;
>       char *desc;
>-      char *flags;
>+      signed char *flags;
>       short *nums;
>       const char **strs;
>       /* Storage area for terminfo data */

Isn't int8_t more appropriate?

christos