Re: CVS commit: src/sys

[Darran Hunt <darran%NetBSD.org@localhost>]

The new code is modular - it has its own kern_dtrace.c module.  I'm  
not sure that replacing the #ifdefs with stub functions is the best  
idea - won't that make the proc and lwp functions a bit less efficient  
with calls to the empty functions?

On 21/02/2010, at 6:31 PM, Mindaugas Rasiukevicius wrote:

> Quentin Garnier <cube%cubidou.net@localhost> wrote:
> > On Sun, Feb 21, 2010 at 02:11:40AM +0000, Darran Hunt wrote:
> > > Module Name:    src
> > > Committed By:   darran
> > > Date:           Sun Feb 21 02:11:40 UTC 2010
> > >
> > > Modified Files:
> > >         src/sys/arch/i386/i386: trap.c vector.S
> > >         src/sys/kern: kern_lwp.c kern_proc.c kern_synch.c
> > >         src/sys/sys: lwp.h proc.h
> > > Added Files:
> > >         src/sys/sys: dtrace_bsd.h
> > >
> > > Log Message:
> > > Add the DTrace hooks to the kernel (KDTRACE_HOOKS config option).
> >
> > Please defflag that option in conf/files and use the resulting  
> > include
> > file as necessary.
>
> I think these #ifdefs for KDTRACE_HOOKS should be removed and empty  
> stubs
> provided for no-DTrace case.  Code will get cleaner and perhaps more  
> modular.
>
> --
> Mindaugas