Source-Changes-D archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: src/sys/dev/i2o
> Modified Files:
> src/sys/dev/i2o: iop.c
>
> Log Message:
> Fix bus_dmamap_sync(): it should be a BUS_DMASYNC_POSTWRITE after
> writing to DMA memory.
> Found by code inspection.
> *sw = htole32(0);
> bus_dmamap_sync(sc->sc_dmat, sc->sc_scr_dmamap, 0, sizeof(*sw),
> - BUS_DMASYNC_PREWRITE|BUS_DMASYNC_PREREAD);
> + BUS_DMASYNC_POSTWRITE);
This looks wrong. POSTWRITE should be used after
xfer from host to device is complete.
It looks bus_dmamap_sync() before *sw = htole32(0) statement
should be POSTWRITE (for the previous xfer) instead.
(POLL() macro with bus_dmamap_sync() seems also wrong..)
---
Izumi Tsutsui
Home |
Main Index |
Thread Index |
Old Index