Re: CVS commit: src/sys/kern

[Antti Kantee <pooka%NetBSD.org@localhost>]

On Thu Mar 04 2010 at 20:05:08 +0200, Antti Kantee wrote:
> On Thu Mar 04 2010 at 14:11:27 +0200, Antti Kantee wrote:
> > On Thu Mar 04 2010 at 14:55:46 +1100, matthew green wrote:
> > > 
> > >    Module Name:   src
> > >    Committed By:  pooka
> > >    Date:          Wed Mar  3 17:58:37 UTC 2010
> > >    
> > >    Modified Files:
> > >           src/sys/kern: kern_module.c
> > >    
> > >    Log Message:
> > >    Replace unsafe use of TAILQ_FOREACH: as the comment says, the
> > >    structures are pulled off the list in the loop and it's anyone's
> > >    guess where they go after that.
> > > 
> > > 
> > > ... i recommend using TAILQ_FOREACH_SAFE().  :-)
> > 
> > Yes.  If only someone had requested a pullup of the documentation to
> > netbsd-5 ... ;)
> 
> actually that's not safe there ...

err, is safe, like even the original before my change was.  i'll stop
writing random emails now.