Re: CVS commit: src/lib/libedit

[Takehiko NOZAKI <takehiko.nozaki%gmail.com@localhost>]

oh, i see. i don't recognize NARROW_READ flag.
source/binary compatibility are still **kept**,
i withdrawn previous mail, sorry.


BTW, this hack is not good for  MB_CUR_MAX > 1 case.
if el_set(EL_GETCFN) called without EL_BUILTIN_GETCFN,
we can't treat multibyte correctly.
# because where we convert multibyte -> wide-character is
# EL_BUILTIN_GETCFN(=read_char) itself.


very truly yours.
-- 
Takehiko NOZAKI<takehiko.nozaki%gmail.com@localhost>


2010/3/7 Christos Zoulas <christos%zoulas.com@localhost>:
> On Mar 7,  5:24am, takehiko.nozaki%gmail.com@localhost (Takehiko NOZAKI) 
> wrote:
> -- Subject: Re: CVS commit: src/lib/libedit
>
> | -typedef int (*el_rfunc_t)(EditLine *, char *);
> | +typedef int (*el_rfunc_t)(EditLine *, Char *);
> |
> |  typedef struct el_read_t {
> |         el_rfunc_t      read_char;      /* Function to read a character */
> |
> |
> | what shoulld we do to solve this problem?
> |  i believe tempolary backout this patch is the way we have to go.
>
> Are you sure? because the code handles the narrow case?
> (That is what the NARROW_READ flag is for.
>
> | # i'm now started completely rewriting wide-character support for libedit.
> | # but it still need lots of time.
>
> Good luck.
>
> christos