Re: CVS commit: src/sys/dev/acpi

[Constantine Aleksandrovich Murenin <C++%Cns.SU@localhost>]

This doesn't sound right:  if sysmon_envsys(9) functions are
specifically used in these drivers, then depending on header pollution
for the prototypes of these functions instead of explicitly including
<dev/sysmon/sysmonvar.h> sounds like a definite bug, not at all a
feature.

C.

On 05/03/2010, Jukka Ruohonen <jruoho%netbsd.org@localhost> wrote:
> Module Name:    src
>  Committed By:   jruoho
>
> Date:           Fri Mar  5 14:00:17 UTC 2010
>
>  Modified Files:
>         src/sys/dev/acpi: acpi.c acpi_acad.c acpi_apm.c acpi_bat.c
>             acpi_button.c acpi_ec.c acpi_lid.c acpi_madt.c acpi_pci.c
>             acpi_pci_link.c acpi_powerres.c acpi_quirks.c acpi_resource.c
>             acpi_slit.c acpi_srat.c acpi_timer.c acpi_tz.c acpi_wakedev.c
>             aiboost.c asus_acpi.c atk0110.c atppc_acpi.c attimer_acpi.c
>             com_acpi.c dalb_acpi.c fdc_acpi.c hpet_acpi.c hpqlb_acpi.c
>             joy_acpi.c lpt_acpi.c mpu_acpi.c pckbc_acpi.c pcppi_acpi.c
>             smbus_acpi.c sony_acpi.c spic_acpi.c thinkpad_acpi.c ug_acpi.c
>             wb_acpi.c wmi_acpi.c wss_acpi.c ym_acpi.c
>
>  Log Message:
>  Remove <dev/acpi/acpica.h> from all files. It is included from
>  <dev/acpi/acpivar.h>. Ditto for <dev/sysmon/sysmonvar.h>, <sys/bus.h>,
>  <dev/pci/pcivar.h>, and <dev/isa/isavar.h>.
>
>  Also nuke a lot of unused and invalid headers. Some of these are audibly
>  provided by standard headers (namely <sys/param.h> and <sys/device.h>), some
>  have nothing to do with ACPI devices (e.g. <sys/syslog.h>), and some are
>  nonexistent local includes (e.g. "mpu_ym.h"). Moreoever, try to group the
>  includes into their respective blocks.
>
>  Tested with GENERIC and ALL (i386). No functional change.
>
>
>
>  To generate a diff of this commit:
>
> cvs rdiff -u -r1.154 -r1.155 src/sys/dev/acpi/acpi.c
>  cvs rdiff -u -r1.41 -r1.42 src/sys/dev/acpi/acpi_acad.c
>  cvs rdiff -u -r1.14 -r1.15 src/sys/dev/acpi/acpi_apm.c \
>     src/sys/dev/acpi/acpi_timer.c src/sys/dev/acpi/sony_acpi.c \
>     src/sys/dev/acpi/wmi_acpi.c
>  cvs rdiff -u -r1.83 -r1.84 src/sys/dev/acpi/acpi_bat.c
>  cvs rdiff -u -r1.33 -r1.34 src/sys/dev/acpi/acpi_button.c
>  cvs rdiff -u -r1.61 -r1.62 src/sys/dev/acpi/acpi_ec.c
>  cvs rdiff -u -r1.35 -r1.36 src/sys/dev/acpi/acpi_lid.c
>  cvs rdiff -u -r1.20 -r1.21 src/sys/dev/acpi/acpi_madt.c
>  cvs rdiff -u -r1.2 -r1.3 src/sys/dev/acpi/acpi_pci.c \
>     src/sys/dev/acpi/acpi_slit.c src/sys/dev/acpi/acpi_srat.c \
>     src/sys/dev/acpi/acpi_wakedev.c
>  cvs rdiff -u -r1.15 -r1.16 src/sys/dev/acpi/acpi_pci_link.c
>  cvs rdiff -u -r1.10 -r1.11 src/sys/dev/acpi/acpi_powerres.c \
>     src/sys/dev/acpi/acpi_quirks.c src/sys/dev/acpi/ym_acpi.c
>  cvs rdiff -u -r1.31 -r1.32 src/sys/dev/acpi/acpi_resource.c
>  cvs rdiff -u -r1.60 -r1.61 src/sys/dev/acpi/acpi_tz.c
>  cvs rdiff -u -r1.29 -r1.30 src/sys/dev/acpi/aiboost.c
>  cvs rdiff -u -r1.17 -r1.18 src/sys/dev/acpi/asus_acpi.c
>  cvs rdiff -u -r1.8 -r1.9 src/sys/dev/acpi/atk0110.c \
>     src/sys/dev/acpi/dalb_acpi.c src/sys/dev/acpi/smbus_acpi.c
>  cvs rdiff -u -r1.16 -r1.17 src/sys/dev/acpi/atppc_acpi.c
>  cvs rdiff -u -r1.13 -r1.14 src/sys/dev/acpi/attimer_acpi.c
>  cvs rdiff -u -r1.30 -r1.31 src/sys/dev/acpi/com_acpi.c
>  cvs rdiff -u -r1.37 -r1.38 src/sys/dev/acpi/fdc_acpi.c
>  cvs rdiff -u -r1.4 -r1.5 src/sys/dev/acpi/hpet_acpi.c
>  cvs rdiff -u -r1.6 -r1.7 src/sys/dev/acpi/hpqlb_acpi.c
>  cvs rdiff -u -r1.9 -r1.10 src/sys/dev/acpi/joy_acpi.c \
>     src/sys/dev/acpi/mpu_acpi.c
>  cvs rdiff -u -r1.18 -r1.19 src/sys/dev/acpi/lpt_acpi.c
>  cvs rdiff -u -r1.32 -r1.33 src/sys/dev/acpi/pckbc_acpi.c
>  cvs rdiff -u -r1.11 -r1.12 src/sys/dev/acpi/pcppi_acpi.c
>  cvs rdiff -u -r1.5 -r1.6 src/sys/dev/acpi/spic_acpi.c \
>     src/sys/dev/acpi/ug_acpi.c
>  cvs rdiff -u -r1.27 -r1.28 src/sys/dev/acpi/thinkpad_acpi.c
>  cvs rdiff -u -r1.1 -r1.2 src/sys/dev/acpi/wb_acpi.c
>  cvs rdiff -u -r1.25 -r1.26 src/sys/dev/acpi/wss_acpi.c
>
>
>  Please note that diffs are not public domain; they are subject to the
>  copyright notices on the relevant files.