Re: CVS commit: src/sys

[Paul Goyette <paul%whooppee.com@localhost>]

Yeah, in retrospect that would probably have been a simpler course to 
follow.

I'd be happy to re-work this if you want, but it will probably take a 
couple days - the day job needs some attention right now.

On Tue, 25 May 2010, David Young wrote:

> On Mon, May 24, 2010 at 08:29:49PM +0000, Paul Goyette wrote:
> > Module Name:    src
> > Committed By:   pgoyette
> > Date:           Mon May 24 20:29:49 UTC 2010
> >
> > Modified Files:
> >         src/sys/arch/i386/pci: gcscehci.c
> >         src/sys/dev/cardbus: ehci_cardbus.c ohci_cardbus.c uhci_cardbus.c
> >         src/sys/dev/pci: azalia.c cs4280.c ehci_pci.c ohci_pci.c uhci_pci.c
> >
> > Log Message:
> > Update all callers of the pci_find{vendor,product} routines to now call
> > these routines through their global pointers.
>
> It was not necessary to change all of the pci_find{vendor,product}
> calls, was it?  You could have tucked the call through
> pci_find{vendor,product}_vec into pci_find{vendor,product}() like this:
>
> const char *
> pci_findvendor(pcireg_t id)
> {
>         return (*pci_findvendor_vec)(id);
> }
>
> Dave
>
> --
> David Young             OJC Technologies
> dyoung%ojctech.com@localhost      Urbana, IL * (217) 278-3933

-------------------------------------------------------------------------
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com    |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer |                          | pgoyette at netbsd.org  |
-------------------------------------------------------------------------