Re: CVS commit: src

[Paul Goyette <paul%whooppee.com@localhost>]

Thanks, John, for all the help and feedback.  I will go back through all 
of the xxxverbose modules in the next few days and make the suggested 
updates.

Some answers to your questions:

> } @@ -106,7 +107,12 @@
> }       KASSERT(ifattr && !strcmp(ifattr, "pci"));
> }       KASSERT(locators);
> }
> } +     pci_verbose_ctl(true);  /* Try to load the pciverbose module */
> } +
>
>     Does this only cover boot time, or will it also cover bus rescans
> (i.e. drvctl -r)?

I hadn't considered 'drvtl -r'.  I will investigate if this covers it.

> } +             return;
> }       }
> } -#endif
> } -     return (NULL);
> } +     if (--loaded == 0)
> } +             module_unload("pciverbose");
>
>     There is no need to forcibly unload the module.  Let the MODULAR
> subsystem and/or administrator handle this.

I guess I'm still not clear on what determines if the MODULAR subsystem 
will actually unload a module.  I will go back and re-re-read the code.


-------------------------------------------------------------------------
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com    |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer |                          | pgoyette at netbsd.org  |
-------------------------------------------------------------------------