Re: CVS commit: src/sys/rump/librump/rumpkern

[Alistair Crooks <agc%pkgsrc.org@localhost>]

On Tue, Jun 15, 2010 at 04:40:24PM +1000, matthew green wrote:
> 
> > On Mon, Jun 14, 2010 at 09:40:37AM -0600, M. Warner Losh wrote:
> >  > On i386, that's true.  amd64 expands to '0', as does sun3.  This makes
> >  > the first one true.  The second one, i386 expands to '1', so the
> >  > second one would be false.
> > 
> > Arguably we shouhld fix our gcc to only define "__i386__", not "i386",
> > which conflicts with the user namespace...
> 
> i agree.
> 
> i was going to reply to an earlier message on this that it was the
> kernel Makefile's that define $MACHINE, but upon looking at them i
> noticed that only a few do, and that i486--netbsdelf-gcc defines
> "i386" all the time.... so i didn't send any email.
> 
> we should audit all of our gcc configs and kernel configs to deal.

Yes, I agree, too.

Quite some time ago, we stopped defining "unix", which mainly
caused issues in pkgsrc and not in src, but nothing we couldn't
overcome given time and bulk builds.

Now's not the time, though, please leave it 2 weeks :-)

Best,
Alistair