Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/crypto/external/bsd/netpgp/dist/src/lib



On Sat, Jun 26, 2010 at 06:18:11AM +0200, Alistair Crooks wrote:
> It would be better to make this a check which is size_t dependent,
> rather than platform-dependent.

The idea is to black list platforms that don't do %zu and there is no
way to do that without breaking cross-compilation. It is still
preferable to use that if it is available, e.g. to help format string
checks.

> I still don't understand why autoconf is passing C pre-processor
> directives down.
> 
> #if sizeof(size_t) == sizeof(int)
> ...
> #elif sizeof(size_t) == sizeof(long)
> ...
> #endif
> 
> directly in the code is much more readable.

Doesn't work as the preprocessor doesn't know what sizeof(size_t) is.
The macros are pre-computed similar to what genassym is doing for the
NetBSD kernel build.

Joerg


Home | Main Index | Thread Index | Old Index