Re: CVS commit: src/sys/dev/sysmon

[Antti Kantee <pooka%NetBSD.org@localhost>]

On Sat Oct 23 2010 at 01:49:25 +0000, Jonathan A. Kollasch wrote:
> On Wed, Oct 20, 2010 at 06:50:47PM +0000, Antti Kantee wrote:
> > Module Name:        src
> > Committed By:       pooka
> > Date:               Wed Oct 20 18:50:47 UTC 2010
> > 
> > Modified Files:
> >     src/sys/dev/sysmon: swsensor.c
> > 
> > Log Message:
> > remove unused routine (per comment)
> > 
> > 
> > To generate a diff of this commit:
> > cvs rdiff -u -r1.1 -r1.2 src/sys/dev/sysmon/swsensor.c
> 
> This breaks the i386 ALL kernel.

Ok, I put it back apart from the incorrect comment.  Thanks.

> Also, weren't you one of the folks advocating everyone
> run a release build before committing anything?

No, I was advocating running a release build *after* committing and
checking the code out to a clean tree.  I am also advocating on using
good judgment in how to test commits.  In this case believing the comment
and testing only that part was not good judgment, though.

btw, ALL is not part of a release build ;)