Re: CVS commit: src/sys/kern

[yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi)]

hi,

> Hello,
> 
> Sorry for late reply.
> 
> yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi) wrote:
>> >>> 
>> >>> how about the attached patch?
>> >> 
>> >> Consider offset = (INT64_MAX - PAGE_SIZE) and len = PAGE_SIZE.  That
>> >> would still panic..
>> > 
>> > heh, right.
>> > 
>> > then, how about:
>> >    if (round_page(offset) < trunc_page(endoffset)) {
>> 
>>              && offset < round_page(offset)
> 
> I think that should be correct, except there is off-by-one (since offset
> at PAGE_SIZE boundary is valid).  Should be:
> 
>       ... && offset <= round_page(offset)

heh, sure.

> 
> Do you want to commit this?

if you can test and commit, please.

YAMAMOTO Takashi

> 
> -- 
> Mindaugas