Re: CVS commit: src/sys/dev/pci

[David Laight <david%l8s.co.uk@localhost>]

On Sun, Dec 12, 2010 at 07:17:35PM -0800, Matt Thomas wrote:
> 
> On Dec 12, 2010, at 10:56 AM, David Young wrote:
> 
> > On Sat, Dec 11, 2010 at 11:18:12PM -0800, Matt Thomas wrote:
> >> On Dec 11, 2010, at 11:02 AM, David Young wrote:
> >>> Why does this need to be #ifdef'd ?
> >> 
> >> It doesn't but it never ever match on anything other
> >> than a PowerPC so why have the code when it can never
> >> be executed?
> > 
> > IMO, it's not worth a few bytes' savings in instructions to clutter code
> > with conditional compilation.
> 
> And maybe that's why NetBSD kernels continue to bloat in size.
> 
> Removing code from a kernel that could never be executed is a great
> use of condition compilation.
> 

My preference would be to #if the header to #define away the function call
(instead of defining the prototype)

        David

-- 
David Laight: david%l8s.co.uk@localhost