Re: CVS commit: src/sys/kern

[Antti Kantee <pooka%cs.hut.fi@localhost>]

On Fri Dec 17 2010 at 22:34:04 +0000, YAMAMOTO Takashi wrote:
> Module Name:  src
> Committed By: yamt
> Date:         Fri Dec 17 22:34:04 UTC 2010
> 
> Modified Files:
>       src/sys/kern: vfs_lookup.c
> 
> Log Message:
> - lookup_once: when crossing a mount point, don't keep the parent vnode 
> locked.
>   ie. don't lock a vnode while holding another vnode which belongs to a
>   different filesystem.  otherwise we propagate slowness (or deadness) of a
>   filesystem to another via vnode lock chain.
> - lookup_parsepath: don't alter vnode states.  let the caller do it instead.
> - add comments and assertions.

Hi, this breaks the state->dp != ndp->ni_dvp invariant in at least 3
places in vfs_lookup.c:

http://www.gson.org/netbsd/bugs/build/build/2010.12.18.09.26.57/test.html#failed-tcs-summary

Can you have a look?

-- 
älä karot toivorikkauttas, kyl rätei ja lumpui piisaa