-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello, On Dec 24, 2010, at 4:13 AM, Christoph Egger wrote:
On 24.12.10 00:56, Michael wrote:Hello, On Dec 23, 2010, at 4:34 PM, Christoph Egger wrote:Module Name: src Committed By: cegger Date: Thu Dec 23 21:34:02 UTC 2010Modified Files: src/sys/dev/pci: voyagerfb.cLog Message: read 32bits instead of 64bits and truncate the upper 32bitsPlease stop making unnecessary changes to drivers you can't test on actual hardware.Sorry, should have mentioned this makes the i386 ALL kernel linking.
Are you trying to tell me that i386 doesn't have bus_space_*_8() methods? I'd call that a bug. The 64bit access in voyagerfb was most likely a typo on my side but there is hardware which has registers that must be accessed in 64bit quantities and voyagerfb was written for a machine with a 64bit CPU - you can't blindly assume that 64bit accesses can be split up. That said, I very much doubt that there is a lot of x86 hardware out there which uses Silicon Motion SM50x chips, so adding that driver to anything in i386 makes little sense. For starters, it doesn't bother with VGA compatibility.
have fun Michael -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) iQEVAwUBTRSb8MpnzkX8Yg2nAQIbqgf/T5O9a6abvO2Be6MUMxki2DXkpFIEmaVD Uc7JZf/xlog63rbaqlo/7rNT8+wxYNWZ8Cx5sFtdNdzqD6cNwkN6ByS/Ufk7EYJA PQVFk7uWtdImQV7g2rV8RCwe5Irpxk/AUExpAxlk1FcWIeVR/BE/enDJfU5yUSLl mXp3SQ3nnTJRm0o3lglRCxgsN7gm7nCgJvR5q1INKlOiboodW+9K1/hYWh/D2k29 VTc8slGjTmXxfWEkydFgW3MqylwBr8TlRe6cr1u2cjM/2zFwIrBdajH9OSGug2Oq 8cp7ZzKmPjqwK6o2BUa3EyI3C8JEokjtXZ8Bv2wdS/Xvx9FU2l8i4g== =BZHp -----END PGP SIGNATURE-----