Source-Changes-D archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: src/sys
David Laight <david%l8s.co.uk@localhost> wrote:
> On Sat, Feb 19, 2011 at 08:19:54PM +0000, Matt Thomas wrote:
> >
> > Log Message:
> > Default PCU_UNIT_COUNT to 0. If 0, don't compile the contents of
> > subr_pcu.c and don't include the pcu related members into struct lwp.
>
> Making a structure layout depend on an option is probably not a good idea!
> At least not unless the structure ends with a series of 'optional'
> sub-stuctures that are found by access functions (which may be
> #defines for things built into the kernel itself).
Right. I have asked Matt to not #ifdef in struct lwp as well.
--
Mindaugas
Home |
Main Index |
Thread Index |
Old Index