Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev



On Thu, May 26, 2011 at 4:12 PM, David Holland
<dholland-sourcechanges%netbsd.org@localhost> wrote:
> On Wed, May 25, 2011 at 04:33:38PM +0000, Masao Uebayashi wrote:
>  > Modified Files:
>  >      src/sys/dev/bluetooth: bcsp.c bthub.c btuart.c
>  >      src/sys/dev/ieee1394: fwdev.c fwmem.c fwohci.c
>  >
>  > Log Message:
>  > Declare cfdrivers using extern rather than including ioconf.h.
>
> This is wrong. Please revert it.
>
> The purpose of declaring things in header files is to make sure all
> uses are consistent.

In general yes.  In this paticular case no.

>
> --
> David A. Holland
> dholland%netbsd.org@localhost
>


Home | Main Index | Thread Index | Old Index