On 5/26/11 5:10 PM, Lars Heidieker wrote:
Hi, with those changes I can't compile a kernel without USERCONF option set. The changes in x86_machdep.c should be with in if defs on that options Ok to commit the attached patch? @@ -178,6 +182,7 @@ module_init_md(void) } #endif /* MODULAR */ +#if defined(USERCONF) void userconf_bootinfo(void) { @@ -197,6 +202,7 @@ userconf_bootinfo(void) userconf_parse(bi->text); } } +#endif /* defined USERCONF) */
Missing ( before USERCONF.Also, this is defining userconf_bootinfo conditionally. Did you validate that all callers are protected by USERCONF as well? (An alternative would be to make the body of userconf_bootinfo conditional, not the function itself.