Re: CVS commit: src/tests/syscall

[Matthias Scheler <tron%NetBSD.org@localhost>]

On Sun, May 29, 2011 at 02:57:14PM +0100, Julio M. Merino Vidal wrote:
> On 5/29/11 1:57 PM, Matthias Scheler wrote:
> >Modified Files:
> >     src/tests/syscall: t_pollts.c
> >
> >Log Message:
> >[...]
> >Also use ATF_REQUIRE_EQ_MSG() instead of ATF_REQUIRE_MSG() to avoid
> >crashes if one of the required conditions isn't met.
> 
> It could be a bug in the macro.  I tried changing the last
> ATF_REQUIRE_EQ_MSG call in the program to ATF_REQUIRE_MSG but it did
> not fail.  And I tried adding an explicitly-failing ATF_REQUIRE_MSG
> and did not see a crash either...

I don't think it's a bug in the macro. The problem was that it use the
0 value as the format string which caused a crash. I'm not sure
why I haven't seen this before.

        Kind regards

-- 
Matthias Scheler                                  http://zhadum.org.uk/