Re: CVS commit: src/crypto/external/bsd/openssl/lib/libcrypto/arch/x86_64

[Jean-Yves Migeon <jeanyves.migeon%free.fr@localhost>]

On 17.07.2011 23:18, David Laight wrote:
>>> The .byte streams are required for the inclusion of the AES NI
>>> instructions, which are not supported with our current gcc version.
>>>
>>> Should be fixed once we have stabilized gcc 4.5 (dunno about other
>>> compilers though, especially pcc).
>>
>> That doesn't make any sense. This are *assembler* instructions, not GCC
>> intrinsics.

nm, sorry; was thinking about gas, not gcc.

> Also, having looked at the file, even if it is using instructions that
> the assembler can't process, it is a horrid mess.
> There are much better ways to specify instructions than just .byte sequences.
> Even if you aren't using CPP, the assmembler will support local constants
> and expressions.
> Even a few comments would help.

IIRC, this is the code as generated by the Perl scripts in openssl (byte
streams and the resulting ugliness are neither my own nor spz@).
I tend to steer away from manipulating code (particularly crypto) when I
don't have good knowledge of it. And this is far from being the case for
me with OpenSSL.

Anyway, I'll look into it next week for cleanup.

-- 
Jean-Yves Migeon
jeanyves.migeon%free.fr@localhost