Re: CVS commit: src/sys/sys

[David Holland <dholland-sourcechanges%netbsd.org@localhost>]

On Tue, Jul 05, 2011 at 03:13:02PM +0200, Joerg Sonnenberger wrote:
 > > Log Message:
 > > The manipulation macros for struct dirent are also used by the ufs/ffs
 > > code to manipulate the similar but not identical struct direct. For
 > > this reason they must remain type-polymorphic. Rev 1.25 broke that
 > > property, so put it back by using typeof. Fixes PR 45119.
 > 
 > Please revert this and give UFS/FFS a custom copy. Using very GCC
 > specific C extensions is not appropiate here.

Did you actually read the diff? It's in an ifdef gcc block that was
already using a gcc extension... that you put there.

UFS should obviously have its own set of macros for its own type, as I
wrote in the comment I added, but doing that switchover safely is not
particularly trivial and needs to wait until someone's willing to
thrash it properly.

-- 
David A. Holland
dholland%netbsd.org@localhost