Joerg Sonnenberger <joerg%britannica.bec.de@localhost> writes: > On Fri, Aug 19, 2011 at 09:19:46AM -0400, Jim Wise wrote: >> As long as I remember, we've had a strict policy of submitting changes >> upstream where possible, but of _not_ gating fixes on this process -- >> particularly fixes which are security or correctness related (the latter >> includes fixes without which we'd have to break our policy that all code >> should compile with -Wall -Werror). > > Some of the code changed here has its authoritive source in pkgsrc. > The "gating" is just an excuse for not doing it properly and increasing > maintainance burden without no reason at all. If Christos maintains > something and likes to pay the price, I don't care. This is not true > here though. It is especially true for something where the compiler is > just plainly wrong. Alas GCC has a long history of not choosing a good > balance between noise and actual warnings. And the project has a long history of making sure all (these days: most) code in the base distribution builds with -Wall -Werror. This isn't because every GCC warning is right, of course -- it's because when you turn off warnings for a whole file, you risk hiding another warning which _is_ a sign of an actual code problem. -- Jim Wise jwise%draga.com@localhost
Attachment:
pgpwtPTQ8J72_.pgp
Description: PGP signature