Re: CVS commit: src/common/lib/libc/string

["Valeriy E. Ushakov" <uwe%stderr.spb.ru@localhost>]

On Mon, Aug 22, 2011 at 12:48:22 +0200, Joerg Sonnenberger wrote:

> On Mon, Aug 22, 2011 at 01:26:24AM +0000, David Holland wrote:
> > On Mon, Aug 22, 2011 at 03:13:29AM +0200, Joerg Sonnenberger wrote:
> >  > On Sun, Aug 21, 2011 at 11:37:08PM +0000, David Holland wrote:
> >  > > On Mon, Aug 22, 2011 at 01:31:31AM +0200, Joerg Sonnenberger wrote:
> >  > >  > > Modified Files:
> >  > >  > >   src/common/lib/libc/string: popcount32.c popcount64.c
> >  > >  > > 
> >  > >  > > Log Message:
> >  > >  > > Requires stdint.h.
> >  > >  > 
> >  > >  > No?
> >  > > 
> >  > > uh what?
> >  > 
> >  > It doesn't. The prototypes in strings.h already ensure that
> >  > uint32_t/uint64_t are present and that's the only thing it could ever
> >  > need from stdint.h.
> > 
> > Yes it does. strings.h is included by string.h and is therefore not
> > allowed to include stdint.h itself.
> 
> You are skinning the wrong cat. string.h shouldn't include strings.h in
> first place.

#if defined(_NETBSD_SOURCE)
#include <strings.h>            /* for backwards-compatibilty */
...

-uwe