Re: CVS commit: src/bin/sh

[David Laight <david%l8s.co.uk@localhost>]

On Tue, Aug 23, 2011 at 06:04:39AM -0400, Christos Zoulas wrote:
> Module Name:  src
> Committed By: christos
> Date:         Tue Aug 23 10:04:39 UTC 2011
> 
> Modified Files:
>       src/bin/sh: expand.c
> 
> Log Message:
> PR/45269: Andreas Gustafsson: Instead of falling off the edge when eating 
> trailing newlines
> if the block has moved, arrange so that trailing newlines are never placed in 
> the string
> in the first place, by accumulating them and adding them only after we've 
> encountered a
> non-newline character. This allows also for more efficient appending since we 
> know how much
> we need beforehand. From FreeBSD.

I've checked - we already had a fix for the bug that the freebsd change
was for (running back off the beginning of the buffer).

The newer gcc's are doing something else unexpected.
Possibly even gcc 4.1.

I'm not sure we should assume that this change fixes the underlying
problem.

        David

-- 
David Laight: david%l8s.co.uk@localhost